Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retreive busBarSectionId and VoltageId not set in modification connec… #546

Merged
merged 14 commits into from
Oct 18, 2024
Merged

retreive busBarSectionId and VoltageId not set in modification connec… #546

merged 14 commits into from
Oct 18, 2024

Conversation

ghazwarhili
Copy link
Contributor

…tivity

etiennehomer
etiennehomer requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@etiennehomer etiennehomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: when modifying the feeder name on side one, there's a NullPointerException in single-line-diagram-server when opening the voltage level on side two. Side's two position shouldn' be changed after a change on side one.

src/main/java/org/gridsuite/modification/server/modifications/BusbarSectionFinderTraverser.java Show resolved Hide resolved
@ghazwarhili
code review remarqs
4879f61
@ghazwarhili
Merge remote-tracking branch 'origin/retreive-voltageLevel-busBarSect…
5a802ba 
…ion-for-modification-connectivity' into retreive-voltageLevel-busBarSection-for-modification-connectivity
@ghazwarhili
fix bug related to adder feeder with null value
ece8753
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
87.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ghazwarhili ghazwarhili merged commit 80a1fac into main Oct 18, 2024
3 checks passed
@ghazwarhili ghazwarhili deleted the retreive-voltageLevel-busBarSection-for-modification-connectivity branch October 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennehomer etiennehomer etiennehomer approved these changes

@thangqp thangqp Awaiting requested review from thangqp

@EtienneLt EtienneLt Awaiting requested review from EtienneLt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghazwarhili @etiennehomer